Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve maintainability and PEP 8 compliance for Chakra trace generator #95

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

TaekyungHeo
Copy link
Contributor

@TaekyungHeo TaekyungHeo commented Jun 11, 2024

Summary

Test Plan

$ pip install .
Processing /Users/theo/chakra
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: protobuf==4.* in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (4.23.4)
Requirement already satisfied: graphviz in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (0.20.1)
Requirement already satisfied: networkx in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (3.2.1)
Requirement already satisfied: pydot in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (2.0.0)
Requirement already satisfied: pyparsing>=3 in /Users/theo/venv/lib/python3.10/site-packages (from pydot->chakra==0.0.4) (3.1.1)
Building wheels for collected packages: chakra
  Building wheel for chakra (pyproject.toml) ... done
  Created wheel for chakra: filename=chakra-0.0.4-py3-none-any.whl size=51730 sha256=c39e4c1c3bd8ed8f8cf590fe6e6bcbc7956490c3c158178212dd63fc8fa85d35
  Stored in directory: /private/var/folders/z0/c9mq5j4s6n14n0_gs7nlt6mc0000gp/T/pip-ephem-wheel-cache-ejdfuipi/wheels/fa/dc/75/2163b4163bf1e9cf3c7f1cf69fa03716fb707b8c4f5cb271e8
Successfully built chakra
Installing collected packages: chakra
  Attempting uninstall: chakra
    Found existing installation: chakra 0.0.4
    Uninstalling chakra-0.0.4:
      Successfully uninstalled chakra-0.0.4
Successfully installed chakra-0.0.4

$ chakra_generator 

$ ls
two_comp_nodes_dependent.61.et
two_comp_nodes_dependent.62.et
two_comp_nodes_dependent.63.et
two_comp_nodes_dependent.7.et
two_comp_nodes_dependent.8.et
two_comp_nodes_dependent.9.et
two_comp_nodes_independent.0.et
two_comp_nodes_independent.1.et
two_comp_nodes_independent.10.et
two_comp_nodes_independent.11.et
two_comp_nodes_independent.12.et
two_comp_nodes_independent.13.et
two_comp_nodes_independent.14.et
two_comp_nodes_independent.15.et
two_comp_nodes_independent.16.et
two_comp_nodes_independent.17.et
two_comp_nodes_independent.18.et
two_comp_nodes_independent.19.et
two_comp_nodes_independent.2.et
two_comp_nodes_independent.20.et
two_comp_nodes_independent.21.et
two_comp_nodes_independent.22.et
two_comp_nodes_independent.23.et
two_comp_nodes_independent.24.et
two_comp_nodes_independent.25.et
two_comp_nodes_independent.26.et
two_comp_nodes_independent.27.et
two_comp_nodes_independent.28.et
two_comp_nodes_independent.29.et
two_comp_nodes_independent.3.et
two_comp_nodes_independent.30.et
two_comp_nodes_independent.31.et
two_comp_nodes_independent.32.et
two_comp_nodes_independent.33.et
two_comp_nodes_independent.34.et
two_comp_nodes_independent.35.et
two_comp_nodes_independent.36.et
two_comp_nodes_independent.37.et
two_comp_nodes_independent.38.et
two_comp_nodes_independent.39.et
two_comp_nodes_independent.4.et
two_comp_nodes_independent.40.et
two_comp_nodes_independent.41.et
two_comp_nodes_independent.42.et
two_comp_nodes_independent.43.et
two_comp_nodes_independent.44.et
two_comp_nodes_independent.45.et
two_comp_nodes_independent.46.et
two_comp_nodes_independent.47.et
two_comp_nodes_independent.48.et
two_comp_nodes_independent.49.et
two_comp_nodes_independent.5.et

@TaekyungHeo TaekyungHeo requested a review from a team as a code owner June 11, 2024 14:55
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@srinivas212 srinivas212 merged commit 905f22f into main Jun 11, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@TaekyungHeo TaekyungHeo deleted the generator-refactor branch June 11, 2024 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants