-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance Uptime #884
Merged
Merged
Instance Uptime #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
EricBAndrews
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Super useful feature for a federated social media app.
Left a couple minor notes on design/wording.
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
Nice 👍 |
EricBAndrews
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an "Uptime" tab to instance pages. Uptime data is fetched from https://lemmy-status.org. Lemmy-status watches a set list of instances - if an instance isn't on that list, the tab won't be shown. I'm storing a list of supported instances as a static property within Mlem - if lemmy-status ever changes their list of supported instances, we'd have to update ours too.
The data refreshes automatically every 30 seconds.
When the instance page is opened, Mlem attempts to contact the instance for site information. If this request fails and the instance is supported by lemmy-status, it'll attempt to show the uptime view instead of
ErrorView
.