Fix optional argument for norm()

mljs · Sep 1, 2023 · c0cfbf1 · c0cfbf1
1 parent bb02eb3
commit c0cfbf1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/matrix.d.ts b/matrix.d.ts
@@ -579,7 +579,7 @@ export abstract class AbstractMatrix {
    * Returns the norm of a matrix.
    * @param type - Norm type. Default: `'frobenius'`.
    */
-  norm(type: 'frobenius' | 'max'): number;
+  norm(type?: 'frobenius' | 'max'): number;
 
   /**
    * Computes the cumulative sum of the matrix elements (in place, row by row).

diff --git a/src/matrix.js b/src/matrix.js
@@ -802,7 +802,8 @@ export class AbstractMatrix {
     return diag;
   }
 
-  norm(type = 'frobenius') {
+  norm(type) {
+    if (type === undefined) type = 'frobenius';
     let result = 0;
     if (type === 'max') {
       return this.max();