-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add check for permutation #230
Conversation
The only thing I am unhappy with is the |
A more general question: What is the intended behaviour if
|
Also, Edit: Well, at least not in all cases, e.g. |
Duplicated values are not treated special in any way or what exactly do you mean by that? I think the comment regarding the checkSetEqual with ordered = TRUE is actually incorrect and should be removed. What I mean by that is that comparing [1, 2, 1] with [1, 1, 2] essentially turns into checking whether all [1, 1, 2] == [1, 1, 2]. This also shows how the duplicated values are being handled. Yes, but the |
Sorting comes after the length check, so this fails? x = c(1, NA)
y = c(1) |
Yes. Note that we check the length twice.
Your example is captured in the first length check Edit: I mean "Yes, this returns FALSE" |
Ok, got it now. I think you could clarify a bit in the documentation, but otherwise good to be merged. |
I added some comments |
Can this be merged @mllg ? |
No description provided.