Skip to content

Commit

Permalink
tests: added acks=1 test to storage resources
Browse files Browse the repository at this point in the history
Signed-off-by: Michal Maslanka <michal@redpanda.com>
(cherry picked from commit ce1ff99)
  • Loading branch information
mmaslankaprv committed Oct 4, 2023
1 parent 9577c8e commit 09e3ce5
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions tests/rptest/tests/storage_resources_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from rptest.services.rpk_consumer import RpkConsumer
from rptest.clients.rpk import RpkTool
from ducktape.utils.util import wait_until
from ducktape.mark import parametrize
from ducktape.mark import matrix
from ducktape.cluster.cluster_spec import ClusterSpec


Expand Down Expand Up @@ -146,13 +146,13 @@ def ready():

wait_until(ready, timeout_sec=30, backoff_sec=5)

def _write(self, msg_size, msg_count):
def _write(self, msg_size, msg_count, acks):
producer = RpkProducer(self.test_context,
self.redpanda,
self.topic,
msg_size,
msg_count=msg_count,
acks=-1)
acks=acks)
producer.start()
producer.wait()
producer.free()
Expand Down Expand Up @@ -200,9 +200,8 @@ def _get_partition_segments(self, partition_idx):
return segments

@cluster(num_nodes=2)
@parametrize(clean_shutdown=False)
@parametrize(clean_shutdown=True)
def test_recovery_reads(self, clean_shutdown):
@matrix(acks=[1, -1], clean_shutdown=[True, False])
def test_recovery_reads(self, clean_shutdown, acks):
"""
Verify the amount of disk IO that occurs on both clean and
unclean restarts.
Expand Down Expand Up @@ -237,7 +236,7 @@ def test_recovery_reads(self, clean_shutdown):
assert (msg_count * msg_size /
self.PARTITION_COUNT) < per_partition_checkpoint_threshold

self._write(msg_size, msg_count)
self._write(msg_size, msg_count, acks)
total_bytes = msg_size * msg_count

# Use low level seastar metrics, because storage log metrics do
Expand Down Expand Up @@ -296,4 +295,6 @@ def test_recovery_reads(self, clean_shutdown):
# the byte count: we have already read >= the total size of data
# on disk.
self._read_tips()
self._read_all(msg_count)
# do not read all messages for acks=1 as they may be lost
if acks == -1:
self._read_all(msg_count)

0 comments on commit 09e3ce5

Please sign in to comment.