net: define a generic parsing exception

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
mmaslankaprv · Apr 12, 2024 · 42f826c · 42f826c
1 parent b13c005
commit 42f826c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/v/net/connection.cc b/src/v/net/connection.cc
@@ -11,7 +11,7 @@
 
 #include "base/seastarx.h"
 #include "net/exceptions.h"
-#include "rpc/service.h"
+#include "net/types.h"
 #include "ssx/abort_source.h"
 
 #include <seastar/core/future.hh>
@@ -85,7 +85,7 @@ std::optional<ss::sstring> is_disconnect_exception(std::exception_ptr e) {
         // Happens on unclean client disconnect, when io_iterator_consumer
         // gets fewer bytes than it wanted
         return "short read";
-    } catch (const rpc::rpc_internal_body_parsing_exception&) {
+    } catch (const net::parsing_exception&) {
         // Happens on unclean client disconnect, typically wrapping
         // an out_of_range
         return "parse error";

diff --git a/src/v/net/types.h b/src/v/net/types.h
@@ -32,4 +32,6 @@ class authentication_exception : public std::runtime_error {
       : std::runtime_error(m) {}
 };
 
+class parsing_exception : public std::exception {};
+
 } // namespace net
diff --git a/src/v/rpc/service.h b/src/v/rpc/service.h
@@ -12,6 +12,7 @@
 #pragma once
 
 #include "base/seastarx.h"
+#include "net/types.h"
 #include "reflection/async_adl.h"
 #include "rpc/parse_utils.h"
 #include "rpc/types.h"
@@ -39,7 +40,7 @@ struct service {
     virtual void setup_metrics() = 0;
 };
 
-class rpc_internal_body_parsing_exception : public std::exception {
+class rpc_internal_body_parsing_exception : public net::parsing_exception {
 public:
     explicit rpc_internal_body_parsing_exception(const std::exception_ptr& e)
       : _what(