Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texts can be styled in iOS #349

Closed
wants to merge 0 commits into from
Closed

Texts can be styled in iOS #349

wants to merge 0 commits into from

Conversation

KarlosQ
Copy link

@KarlosQ KarlosQ commented Jan 17, 2020

Overview

I recover style props from v7 to v8 (titleStyle, cancelTextStyle, confirmTextStyle).

Test Plan

Use titleStyle, cancelTextStyle, confirmTextStyle props in this component.

@KarlosQ KarlosQ requested a review from mmazzarolo January 17, 2020 12:11
@mmazzarolo
Copy link
Owner

Hey @KarlosQ , thanks for submitting a PR.

May I ask you what kind of customization you need to apply to the styles?
The main aim of this component (on the iOS side) is to look "native", so if you're adding style on it to make it look more "native" feel free to start a discussion on adding it directly in the component itself 👍

Otherwise...
In order to increase the maintainability of the component, I'd prefer to provide your own pre-styled Header/ConfirmButton/CancelButton to the customHeaderIOS/customConfirmButtonIOS/customCancelButtonIOS instead.

@KarlosQ
Copy link
Author

KarlosQ commented Jan 17, 2020

Also we could customise text but using customHeaderIOS / customConfirmButtonIOS / customCancelButtonIOS. Example:
customHeaderIOS={props => <DateTimePicker.Header textStyle={newStyle} {...props} />}

@KarlosQ KarlosQ closed this Jan 17, 2020
@KarlosQ KarlosQ deleted the styling-texts-ios branch January 17, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants