Memoized equal check should check a date's milliseconds

[sandergo90]

Overview

Comparing two dates is not possible using the === operator. When you would like to check the equality of two dates, you need to use the getTime() method. Our component was still re-rendering before comparing dates with getTime().

Object equality isn't tested by the internal value of the object, but by identity. In other words, if it isn't the exact same copy of the Date object, it isn't considered equal.

Here we compare the return values of getTime. The getTime method returns an integer representing the number of milliseconds since midnight of January 1, 1970 (the beginning of the Unix epoch).

[mmazzarolo]

Dude, thanks! This has probably never been updated since the time the prop was a number (unix epoch) instead of Date.

[mmazzarolo]

Now this makes me wonder: was the wrong memoization actually fixing the bug react-native-datetimepicker/datetimepicker#54 ?

[mmazzarolo]

I can't reproduce it even with the right memoization check (from this PR) so I'm merging it.
Just to be safe, I'm bumping it as a minor.

[github-actions]

🎉 This PR is included in version 9.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[sandergo90]

No problem! ;) In our app, we have websockets pushing new data. Our parent component is using redux selectors to listen to data changes that websockets push. When websocket pushes new data, the parent is re-rendered, causing the datetimepicker to also re-render, even if the date was correct.