Adding customCancelButton and customConfirmButton types #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you guys for an amazing lib!!
PS: I closed this PR because I had the wrong email in the commit, so the commit's signature was unverified. Consider this Pull Request instead. I am sorry for that!
Overview
The library is missing the
CancelButton
andConfirmButton
components for the iOS only propertiescustomCancelButtonIOS
andcustomConfirmButtonIOS
. I also found a good idea to export their styles, just in case someone (myself included) wants to do some slight changes.All I mentioned works fine, but whenever you try to import any of these two components or their styles you get some red on your code editor. That's because the declaration file is missing these elements. So all I did was I exported from
ìndex.d.ts
theCancelButton
andConfirmButton
components, told the declaration file thecustomConfirmButtonIOS
andcustomCancelButtonIOS
properties were aReact.FunctionComponenet<props>
with some extra props. I also exported the style types of both components.Test Plan
There is not much to do actually, all I did was passing the
buttonTextColorIOS
property to the custom button I was using. For example:If you want to change the button styles, you might want to do something like that: