Skip to content

Commit

Permalink
Fix isHTMLBRElement test (facebookarchive#2278)
Browse files Browse the repository at this point in the history
Summary:
**Summary**

In the Facebook repo mirror, modules in Jest tests are not mocked, but on GitHub they are (as seen from `package.json`). That led to D18831442 passing internally in Sandcastle but failing on Travis. Not a huge deal, we can just add `jest.disableAutomock()`.

We might want to see if we can remove `"automock": true,` from the Jest config in `package.json` to have a more similar environment to Facebook's Jest config.

**Test Plan**

Travis CI should pass now.
Pull Request resolved: facebookarchive#2278

Differential Revision: D18874041

Pulled By: yangshun

fbshipit-source-id: 282c137934dea27259a2b52741c749fb6c332323
  • Loading branch information
yangshun authored and mmissey committed Mar 24, 2020
1 parent bd45476 commit 0720f2d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/component/utils/__tests__/isHTMLBRElement-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

'use strict';

jest.disableAutomock();

const isHTMLBRElement = require('isHTMLBRElement');

test('isHTMLBRElement recognizes null', () => {
Expand Down

0 comments on commit 0720f2d

Please sign in to comment.