Skip to content
This repository has been archived by the owner on Aug 28, 2019. It is now read-only.

Code on a list has grey border and background #86

Closed
dyskette opened this issue Feb 21, 2015 · 4 comments
Closed

Code on a list has grey border and background #86

dyskette opened this issue Feb 21, 2015 · 4 comments

Comments

@dyskette
Copy link

If there are code blocks inside a list, they have a grey border and background just like inline code, as you can see in the next screenshot.

captura de pantalla de 2015-02-20 18 10 52

Inside _typography.scss, lines 107-108 seems to be affecting both elements at the same time.

@mmistakes
Copy link
Owner

I don't know if there is anyway around that without bloating the CSS. Not to mention you don't typically see a large block of code that spans multiple lines placed in an item list, they're usually broken out as their own to be more readable.

It doesn't appear that you are including more than a single line of code in the example above. Why not just make it inline like the code snippet you have in the second list item below it?

@dyskette
Copy link
Author

It's not the only post with block code inside a list, it can be a headache to change them all. In the meantime I workaround this by placing a ">" before "code" in line 101. I may be breaking something else though.

p,
li { 
    > code {

@mmistakes
Copy link
Owner

That looks like a good fix. I don't think it would break anything else.

On Friday, February 20, 2015, Dylan Smith notifications@github.com wrote:

It's not the only post with block code inside a list, it can be a headache
to change them all. In the meantime I workaround this by placing a ">"
before "code" in line 101. I may be breaking something else though.

p,
li {
> code {


Reply to this email directly or view it on GitHub
#86 (comment)
.

mpark pushed a commit to mpark/mpark.github.io that referenced this issue May 12, 2016
@mmistakes
Copy link
Owner

Fixed in 1.7.6

misterwell pushed a commit to misterwell/misterwell.github.io that referenced this issue Jan 17, 2019
- Adjust article styles to correctly display post indexes
- Remove top margin from page titles
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants