Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disqus comments not displayed still #107

Closed
pricelessbrewing opened this issue Nov 26, 2014 · 4 comments
Closed

Disqus comments not displayed still #107

pricelessbrewing opened this issue Nov 26, 2014 · 4 comments

Comments

@pricelessbrewing
Copy link

It's me again, don't want to keep adding to that issue thread since it's different and I have to keep switching usernames.

Added comments: true to each of the following:
post/page's index.md in the /page/index.md
and the _posts/postname.md

Moreover I tried manually setting the var disqus_shortname = 'pricelessbrewing'; instead of site.owner as I only have one author and won't need to change it.

Also tried changing the page.html and post.html after it still wasn't showing up
% if page.comments == true %} and removed the site.owner.disqus_comments == true as it wasn't working with it included, and I want comments on all pages/posts where comments are enabled.

https://github.com/pricelessbrewing/pricelessbrewing.github.io repo

@mmistakes
Copy link
Owner

I just downloaded your repo and built it locally. You're _config.yml is pretty jacked up, that's why Disqus and a bunch of other things aren't working. YAML is super picky and if you don't put spaces in the right spots or use tabs instead of spaces things are going to blow up.

  1. Add 1 space after variables. Instead of title:pricelessbrewing you need to do title: pricelessbrewing
  2. Under owner. Don't put anything after the colon.
  3. Everything under owner: needs to be indented 2 spaces, not 1, and they all need 1 space after the colons.

Here's the cleaned up version. It now loads the site title and everything else that missing before. You still have other stuff you need to cleanup but this should set you in the right direction.

Oh and I would .gitignore your .sass-cache folder too. You don't need that under version control.

# Site wide configuration

title: pricelessbrewing
locale: en_US
url: ""


# Jekyll configuration

permalink:   /:categories/:title/
markdown:    kramdown
sass:
  sass_dir: _sass
  style: compressed
gems:
  - jekyll-sitemap

kramdown:
  auto_ids: true
  footnote_nr: 1
  entity_output: as_char
  toc_levels: 1..6
  use_coderay: false


# Site owner
owner:
  name: Mark
  avatar: biophoto.jpg
  bio: "Homebrewer"
  email: Pricelessbrewing@gmaii.com
  disqus-shortname: pricelessbrewing
  twitter: priceless_mark
  #facebook: #username
  #google:
  #plus: #username
  #analytics: 
  #verify: 
  #ad-client: 
  #ad-slot: 
  #bing-verify: 
  github: pricelessbrewing
  #stackoverflow: #http://stackoverflow.com/users/123456/username
  #linkedin: #username
  #instagram: #username
  #lastfm: #username
  #tumblr: #username
  #pinterest: #username
  #foursquare: #username
  #steam: #username
  #dribbble: #username
  #youtube: #username
  #soundcloud: #username

include: [".htaccess"]
exclude: ["lib", "config.rb", "Capfile", "config", "log", "Rakefile", "Rakefile.rb", "tmp", "less", "*.sublime-project", "*.sublime-workspace", "test", "spec", "Gruntfile.js", "package.json", "node_modules", "Gemfile", "Gemfile.lock", "LICENSE", "README.md"]

screen shot 2014-11-26 at 5 27 17 pm

@pricelessbrewing
Copy link
Author

Thanks, I had the spaces after the variables but it kept giving me a error at line # column # where the space was when github tried to build the website.

The owner: text was probably the worst offender, and explains why I was having so many problems.

@pricelessbrewing
Copy link
Author

Pushed the fixes to github. Disqus is loading now! Thanks!

@mmistakes
Copy link
Owner

Excellent.

cwigington3 pushed a commit to cwigington3/cwigington3.github.io---test that referenced this issue Jan 20, 2017
Solves issue mmistakes#94 with disqus comments being enabled by default globally
theRealSuperMario pushed a commit to theRealSuperMario/therealsupermario.github.io that referenced this issue Jul 18, 2020
dataset attribute, no index_ in evalhook
nweat pushed a commit to nweat/nweat-old-portfolio that referenced this issue Feb 1, 2023
…n/eslint-8.26.0

chore(deps-dev): bump eslint from 8.25.0 to 8.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants