-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate disqus_thread
in HTML id
#1199
Labels
Comments
You have a public repo somewhere I can inspect? Hard to tell what's going on without seeing your actual |
Got it. Looks like this was from #1179
|
mmistakes
added
Status: Accepted
Type: Bug
and removed
Status: Feedback Needed
Type: Support
labels
Aug 23, 2017
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this issue
May 30, 2019
`<section id="disqus_thread"></section>` is set in `_includes/comments.html` and not needed in `_includes/comment-provider/disqus.html`. Fixes mmistakes#1199
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this issue
May 18, 2022
`<section id="disqus_thread"></section>` is set in `_includes/comments.html` and not needed in `_includes/comment-provider/disqus.html`. Fixes mmistakes#1199
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this issue
May 5, 2023
`<section id="disqus_thread"></section>` is set in `_includes/comments.html` and not needed in `_includes/comment-provider/disqus.html`. Fixes mmistakes#1199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bundle update
.bundle exec jekyll build
.Environment informations
github-pages
: 155Expected behavior
No duplicate id for
disqus_thread
in HTML.Steps to reproduce the behavior
Build with
comments.disqus.shortname
, the output HTML has the duplicate id in HTML.The text was updated successfully, but these errors were encountered: