Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab color definition missing #1653

Closed
tlindsay42 opened this issue May 8, 2018 · 0 comments
Closed

GitLab color definition missing #1653

tlindsay42 opened this issue May 8, 2018 · 0 comments
Labels
Status: Accepted Type: Enhancement

Comments

@tlindsay42
Copy link
Contributor

tlindsay42 commented May 8, 2018 •
edited
Loading

Description

The GitLab social icon is defaulting to black because there is no specification.

Environment

Expected behavior

The GitLab icon in the author profile sidebar is set to one of the official brand colors.

Steps to reproduce the behavior

Set the GitLab username in _config.yml

author:
  gitlab: 'tlindsay42'

While served, the GitLab icon that appears in the author profile is black because there is no specification for it in _variables.scss or _utilities.scss.

image

Pull request following momentarily.
@tlindsay42 tlindsay42 mentioned this issue May 8, 2018
Merged
mmistakes pushed a commit that referenced this issue May 8, 2018
@tlindsay42 @mmistakes
#1653: Add GitLab social icon brand color (#1654)
37e5fd1
luispuerto referenced this issue in luispuerto/luispuerto-net Jun 27, 2018
@tlindsay42
#1653: Add GitLab social icon brand color (#1654)
d6a2781
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
@tlindsay42 @mmistakes
mmistakes#1653: Add GitLab social icon brand color (mmistakes#1654)
aecfd45
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this issue Sep 10, 2019
@tlindsay42 @mmistakes
mmistakes#1653: Add GitLab social icon brand color (mmistakes#1654)
ae88b82
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
@tlindsay42 @mmistakes
mmistakes#1653: Add GitLab social icon brand color (mmistakes#1654)
7e19649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Accepted Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmistakes @tlindsay42