Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid urls in feed.xml are generated when site url in _config.yml is protocol-less #288

Closed
kamilszymanski opened this issue Apr 26, 2016 · 1 comment
Closed

Invalid urls in feed.xml are generated when site url in _config.yml is protocol-less #288

kamilszymanski opened this issue Apr 26, 2016 · 1 comment
Assignees
@mmistakes
Labels
Type: Enhancement
Milestone
3.1.3

Comments

@kamilszymanski
Copy link
Contributor

Links are generated based on site url and thus they're missing the protocol and start with just //
@mmistakes
Copy link
Owner

mmistakes commented Apr 26, 2016 •
edited
Loading

Only way around it is either use https:// and forget about being protocol agnostic. Or dump the jekyll-feed plugin and roll your own feed.xml.

It's probably better for SEO purposes to pick https or http and stick with one as site.url is also used to generate canonical URLs in <head>.

If you're hosting on GitHub I honestly can't think of a reason why you wouldn't just stick with https since your site can be accessed both ways regardless of what you put in _config.yml.

For example the MM demo site has a site.url of https://mmistakes.github.io and is accessible at https://mmistakes.github.io/minimal-mistakes/ and http://mmistakes.github.io/minimal-mistakes/

I probably should just remove the mention of protocol-less URLs from the documentation as it apparently is an "anti-pattern" now.

@mmistakes mmistakes added this to the 3.1.3 milestone Apr 26, 2016
@mmistakes mmistakes self-assigned this Apr 26, 2016
sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Apr 29, 2016
@mmistakes @sobkowiak
Remove protocol-less site.url ProTip as it is an anti-pattern
743cadc 
- Close mmistakes#288
cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016
@gynter
Merge pull request mmistakes#288 from TaylanTatli/master
4de9352 
Add Ramme theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmistakes mmistakes

Labels
Type: Enhancement
Projects
None yet
Milestone
3.1.3
Development

No branches or pull requests
2 participants
@mmistakes @kamilszymanski