Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate UI text for new strings #449

Closed
5 tasks done
mmistakes opened this issue Aug 11, 2016 · 4 comments
Closed
5 tasks done

Translate UI text for new strings #449

mmistakes opened this issue Aug 11, 2016 · 4 comments

Comments

@mmistakes
Copy link
Owner

mmistakes commented Aug 11, 2016

As part of #424 several new text strings need translating in /_data/ui-text.yml. Pull requests welcome 😄

  • Spanish
  • Brazilian Portuguese
  • Turkish
  • Italian
  • French
comments_title             : "Comments"
comment_form_info          : "Your email address will not be published. Required fields are marked"
comment_form_comment_label : "Comment"
comment_form_md_info       : "Markdown is supported."
comment_form_name_label    : "Name"
comment_form_email_label   : "Email address"
comment_form_website_label : "Website (optional)"
comment_btn_submit         : "Submit Comment"
comment_btn_submitted      : "Submitted"
comment_success_msg        : "Thanks for your comment! It will show on the site once it has been approved."
comment_error_msg          : "Sorry, there was an error with your submission. Please make sure all required fields have been completed and try again."
loading_label              : "Loading..."
@rschaerer
Copy link
Contributor

In my opinion you would have a more relaxed ☺️ time concerning the "by no means a full-on i18n solution" feature, if you would add all the missing strings in English to the several different translations and append a comment like # translation missing to the corresponding lines like so:

# Turkish
# -----------------
tr: &DEFAULT_TR
  page                       : "Sayfa"
  [...]
  undefined_wpm              : "_config.yml dosyasında tanımlanmamış words_per_minute parametresi"
  comment_form_info          : "Your email address will not be published. Required fields are marked" # translation missing
  [...]

Otherwise the empty keys in the translations which lead to omitting them from view might confuse users which switch the language and didn't read the docs carefully.

How do you think about this? If you agree, I could do the work and create a PR for this.

@mmistakes
Copy link
Owner Author

mmistakes commented Aug 29, 2016

My thought was empty keys fallback to English (what the theme currently does), which should hopefully be a clue when switching languages that they're missing.

Example: {{ site.data.ui-text[site.locale].comments_label | default: "Comments" }}

Previously they were just blank and I noticed quite a few forks where half of the UI text was missing. So I added the English default values as a nudge to consult the docs for those who actually care about such things.

Open to suggestions on ways of better surfacing these sorts of things without making it a maintenance headache or junking up things too much.

@rschaerer
Copy link
Contributor

😄 Ok, I couldn't read the docs and just tried to remove follow_label, which is intended to be omittable. I think the actual fallback to default is exactly what I was thinking about. Thank you for elaborating this to me!

@mmistakes
Copy link
Owner Author

#1278

makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants