Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print stylesheet #909

Closed
1 of 5 tasks
markkm opened this issue Mar 20, 2017 · 0 comments
Closed
1 of 5 tasks

Improve print stylesheet #909

markkm opened this issue Mar 20, 2017 · 0 comments

Comments

@markkm
Copy link

markkm commented Mar 20, 2017

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

The print preview on Chrome seems to add extra blank pages on websites that use the minimal mistake theme.

For example, your quick-start guide page shows up as 8 pages, with 3 blank pages, on Chrome print preview. Compare this to Firefox print preview, which does not add any blank pages.

As another example, here is a page from my own website. Chrome adds 19 blank pages (!) to its print preview, whereas Firefox adds none.

I am using Chrome Version 57.0.2987.110 (64-bit) on Debian Sid.

@mmistakes mmistakes changed the title print preview error on Google Chrome Improve print stylesheet Mar 20, 2017
mmistakes added a commit that referenced this issue Mar 23, 2017
RobinYu added a commit to RobinYu/robinyuuu.github.io that referenced this issue May 8, 2017
* Fix image caption border-radius

* Fix image caption border-radius

* Improve print stylesheet
- Close mmistakes#909

* Update CHANGELOG and history
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
* Fix image caption border-radius

* Fix image caption border-radius

* Improve print stylesheet
- Close mmistakes#909

* Update CHANGELOG and history
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
* Fix image caption border-radius

* Fix image caption border-radius

* Improve print stylesheet
- Close mmistakes#909

* Update CHANGELOG and history
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
* Fix image caption border-radius

* Fix image caption border-radius

* Improve print stylesheet
- Close mmistakes#909

* Update CHANGELOG and history
koyumi0601 pushed a commit to koyumi0601/koyumi0601.github.io that referenced this issue Jul 31, 2023
…equire `mermaid.version` in `_config.yml` (mmistakes#909)

This PR has a bit of scope creep! This PR now:

- changes the mermaid opt-in logic to only check for the existence of a `mermaid` key instead of `mermaid != false`: this resolves the follow-up in mmistakes#857
- changes the behaviour of mermaid configuration
    - instead of using `mermaid_init.html` with default settings, makes the include `mermaid_config.js`
    - the include is loaded directly into the contents of `mermaid_initialize`
    - by default, it is an empty object (i.e. `{}`), triggering the defaults
- updates docs
- adds an example to the markdown kitchen sink  

It does significantly change the interface provided in mmistakes#857, and I apologize for the confusion. However, given the discussion in this PR, I think it's the best move forward!
koyumi0601 pushed a commit to koyumi0601/koyumi0601.github.io that referenced this issue Jul 31, 2023
Short and sweet PR that addresses the follow-up in mmistakes#909: enabling `mermaid` on our docs site, but making it clear that users still need to opt-in to use it. I've also added an example in-action.

To test: [see the Netlify deploy](https://deploy-preview-935--just-the-docs.netlify.app/docs/ui-components/code/#mermaid-diagram-code-blocks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants