Add wide variant to single layout
#1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the "single" layout that puts the right sidebar on top.
|
I am just going to close this and some diligent github user might read it later. |
|
The elegant approach here is to utilize the For a page you'd want the wide variant of you'd do something like: ---
layout: single
classes: wide
---Which would put a .wide {
.page {
// override right padding and width's to make wide
}
.sidebar__right {
// override negative margin, width, positioning, etc.
}
// any other overrides needed for a wide `.page`
} |
|
If you want to take a stab at this I'll review it and see about getting it merged in. |
willow-ahrens
changed the title
|
Looks good @peterahrens, thanks for making the change and resubmitting. |
mmistakes
changed the title
wide variant to single layout
|
Thanks for the tips @mmistakes! |
|
Do you guys have a live demo for this? |
|
Nice! |
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
…single" layout. (mmistakes#1516) Add `wide` variant to single layout
sumeetmondal
pushed a commit
to sumeetmondal/sumeetmondal.github.io
that referenced
this pull request
Sep 10, 2019
…single" layout. (mmistakes#1516) Add `wide` variant to single layout
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
…single" layout. (mmistakes#1516) Add `wide` variant to single layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new layout called "queen." It is a wider version of "single" (yes like the mattress sizes). It puts the right sidebar on top (if you asked for a right sidebar) so that you can get that sweet sweet wide display you've been craving for your programming blog post (80 characters or bust!), without cramping your style in your more literary blog posts. I don't really know if this layout is really worth merging, but I thought I would put it here so somebody might copy what I did instead of bugging mmistakes about widening the margins again.