Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbox sticky footer #2289

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Flexbox sticky footer #2289

merged 3 commits into from
Oct 21, 2019

Conversation

mmistakes
Copy link
Owner

This is a bug fix.
This is an enhancement or feature.

Summary

This PR removes JavaScript that helps force the <footer> to the bottom of short (and tall) pages and clears any content.

Using flexbox on the <body> element, similar results can be achieved.

Context

#2281

@mmistakes mmistakes merged commit 6d28d12 into master Oct 21, 2019
@mmistakes mmistakes mentioned this pull request Oct 28, 2019
kamil-adam pushed a commit to twocolumn/minimal-mistakes that referenced this pull request Apr 1, 2020
* Remove sticky footer JavaScript

* Use flexbox to force footer to the bottom of every page

* Fix flexbox in Internet Explorer
jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this pull request Jul 8, 2020
* Remove sticky footer JavaScript

* Use flexbox to force footer to the bottom of every page

* Fix flexbox in Internet Explorer
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
* Remove sticky footer JavaScript

* Use flexbox to force footer to the bottom of every page

* Fix flexbox in Internet Explorer
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
* Remove sticky footer JavaScript

* Use flexbox to force footer to the bottom of every page

* Fix flexbox in Internet Explorer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant