Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of page excerpt in heading (via tagline) #2307

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

iBug
Copy link
Collaborator

@iBug iBug commented Nov 4, 2019

This is an enhancement or feature.

Summary

Allow the use of page.tagline to override page.excerpt in heading area.

I want to have some custom text that more resembles a "description" of the article in the header area that's designated for the excerpt. However, manually overriding page.excerpt in front matter also changes the excerpt displayed in blog menu / pagination pages, which is a rather undesired impact. Using another variable like page.tagline to override this makes it easier to handle and more flexible to use.

For example, the text [Developer, system administrator, geek] on my front page is actually specified as page.excerpt:

https://github.com/iBug/iBug-source/blob/9837ea293a154b154404a18d533341dc93199cb5/index.md#L3

Context

Not related to any existing GitHub issue. My motivation is exactly as said: The need to customize this part of the theme. Since excerpt is by default automatically gathered from the first few characters of the content, it's less sensible to repeat the exact stuff in page heading.

Rest assured, tagline isn't a special variable (not touched by Jekyll, unlike excerpt which may be automatically generated) and is only specified manually. I picked this name because a few other themes also uses the same name (example) and it's sure to be free of confusion.

Allow the use of `page.tagline` to override `page.excerpt` in heading area
@iBug
Copy link
Collaborator Author

iBug commented Nov 21, 2019

What are the backlashes against this feature?

@stale
Copy link

stale bot commented Dec 22, 2019

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Status: Stale label Dec 22, 2019
@iBug
Copy link
Collaborator Author

iBug commented Dec 22, 2019

Bump

@stale stale bot removed the Status: Stale label Dec 22, 2019
@mmistakes mmistakes merged commit be0e7ca into mmistakes:master Jan 7, 2020
@iBug iBug deleted the patch-1 branch January 7, 2020 18:22
jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this pull request Jul 8, 2020
Allow the use of `page.tagline` to override `page.excerpt` in heading area
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this pull request Jan 4, 2021
Allow the use of `page.tagline` to override `page.excerpt` in heading area
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
Allow the use of `page.tagline` to override `page.excerpt` in heading area
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
Allow the use of `page.tagline` to override `page.excerpt` in heading area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants