Fix compatibility issue with paginate V2 introduced by #2378 #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesuswasrasta
pushed a commit
to jesuswasrasta/jesuswasrasta.github.io
that referenced
this pull request
Jul 8, 2020
mzaffran
pushed a commit
to mzaffran/mzaffran.github.io
that referenced
this pull request
Jan 4, 2021
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
The patches in #2378 introduced a huge issue when paginating collections with paginate V2 plugin, the users of which generally set
site.paginatetofalseor omit it completely to let it default tonull. This however made all collection indices paged withsite.postsinstead ofpaginator.posts.Tested with Jekyll 3.8.6 and latest compatible
jekyll-paginate-v2, thepaginatorobject is available for properly-configured pages, so this change doesn't break the intended functionality of #2378, while fixes the new issue effectively.