add image helper for easier image insertion in posts #572
Conversation
|
Looks good and fits in well with the |
| @@ -0,0 +1,14 @@ | |||
| {% include base_path %} | |||
There was a problem hiding this comment.
I've deprecated the base_path include as Jekyll provides filters to do this now.
| {% if include.image_path contains "://" %} | ||
| "{{ include.image_path }}" | ||
| {% else %} | ||
| "{{ include.image_path | prepend: "/assets/images/" | prepend: base_path }}" |
There was a problem hiding this comment.
can replace prepend: base_path with absolute_url
|
done :-) |
| {% if include.image_path contains "://" %} | ||
| "{{ include.image_path }}" | ||
| {% else %} | ||
| "{{ include.image_path | prepend: "/assets/images/" | absolute_url }}" |
There was a problem hiding this comment.
One more minor thing. With the latest MM I moved away from assuming images would be placed in /assets/images/ and instead encourage adding the full path. Adds more flexibility to where they can be placed for the user.
If you could remove prepend: "/assets/images/" it fall in line with the other helpers and I can merge it in.
In order to add an image to a post, just use the following syntax:
{% include image image_path="/full/path/to/MyPostImage.png" caption="The optional image caption" %}
or
{% include image image_path="https://example.com/images/MyPostImage.png" caption="The optional image caption" alt="The optional alt text" %}
|
Looks like Jekyll core may get a native filter to do something similar. jekyll/jekyll#5560 |
|
I made a small change and renamed the helper from Thanks for your work on this. |
This PR combines (and resolves conflicts between) mmistakes#448, mmistakes#463, mmistakes#466, mmistakes#494, mmistakes#495, mmistakes#496, mmistakes#498, and mmistakes#572. The main aim is to facilitate use of several of the implemented features _together_, when using the fork as a remote theme. It should also simplify merging the included PRs into a future release. The branch [combination-rec-nav](https://github.com/pdmosses/just-the-docs/tree/combination-rec-nav) adds [multi-level navigation](just-the-docs/just-the-docs#462) and (NEW:) [sibling links](just-the-docs/just-the-docs#394) to the branch used for this PR. It includes updated [documentation for the navigation structure](https://pdmosses.github.io/just-the-docs/docs/navigation-structure/), and reorganised and extended [navigation tests](https://pdmosses.github.io/just-the-docs/tests/navigation/). The documentation and the tests can be browsed at the (temporary) [website published from the combination-rec-nav branch](https://pdmosses.github.io/just-the-docs/). _Caveat:_ The changes to v0.3.3 in this PR and mmistakes#462 have not yet been reviewed or approved, and may need updating before merging into a release of the theme. If you use a branch from a PR as a remote theme, there is a risk of such updates affecting your website. Moreover, these branches are likely to be deleted after they have been merged. To avoid such problems, you could copy the branch that you want to use to your own fork of the theme. Co-authored-by: Matt Wang <matt@matthewwang.me>
This PR adds an 'image' helper for easier insertion of image in posts (#560)
It handles both local images (it assumes images are under
assets/images) and urls.in order to add an image to a post, just use the following syntax:
{% include image image_path="2016/07/MyPostImage.png" caption="The optional image caption" %}or
{% include image image_path="https://example.com/images/MyPostImage.png" caption="The optional image caption" alt="The optional alt text" %}Parameters are:
image_path(mandatory): the image path. It can be an url or a local path. In the former case, it assumes images are underassets/images, so you only need to specify the path from there.caption(optional): the image caption.alt(optional): the alt text.What you think?