Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

files missing from tarball #5

Closed
mmitch opened this issue Jul 26, 2015 · 2 comments
Closed

files missing from tarball #5

mmitch opened this issue Jul 26, 2015 · 2 comments

Comments

@mmitch
Copy link
Owner

mmitch commented Jul 26, 2015

There are some files from the source tree that are not included in the tarball:

  • BUGTRACKING - propably OK, because we don't use ditz any more. The file (along with the bugs subdirectory) should be deleted and the open issues should be imported to the git issue tracker. I'd volunteer to do that when I have some time.
  • TESTSUITE - include it?
  • gbsformat.txt - include it?
  • libgbs.def - was checked in regarding Cygwin DLL build. Is this a build result that we forgot to make distclean or should this be in the tarball as well as it's needed for a Windows build?
  • .gitgnore - include it?
@ranma
Copy link
Collaborator

ranma commented Jul 26, 2015

libgbs.def seems to be the cygwin equivalent of libgbs.so.1.ver. It instructs the linker which globals the library should export, to prevent accidentally exporting a symbol that wasn't supposed to be public.
In general I'd say the tarball should include everything from the repository but the .git tree itself.

mmitch added a commit that referenced this issue Aug 16, 2015
@mmitch
add missing files to tarball
1e6c349 
now `make dist' should include everything except the git tree itself

ditz-issues are still to be removed

this mostly fixes github issue #5
@mmitch
Copy link
Owner Author

mmitch commented Aug 23, 2015

I forgot to mention this issue in commit 4c764ad which removes the old ditz issue tracker.
With that, this issue is closed.

@mmitch mmitch closed this as completed Aug 23, 2015
@Wapata Wapata mentioned this issue Nov 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmitch @ranma