add application name and currently playing file to audio streams #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PulseAudio and PipeWire (and SDL when using one of those two as backends) provide a metadata field in the audio stream for the stream name. Don't just hardcode `gbsplay` as the stream name but show which file is currently playing instead.
PulseAudio and PipeWire (and SDL when using one of those two as backends) provide a metadata field in the audio client connection for the application name. Don't just hardcode `gbsplay` as the application name but distinguish between gbsplay and xgbsplay.
Codecov ReportAttention:
Additional details and impacted files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set audio metadata to make application name and currently playing file available to other applications, eg. let pavucontrol (PulseAudio mixer app) show this ( 👁️ bottom row):
I have implemented this for these audio backends:
This might be added to other plugouts, too, but I don't know of they support meta data.
Theoretically we could also use
plugout_skip_fnto append the currently playing subsong, but I did not implement this because for both PipeWire and Pulseaudio we would have to update from their "simple" stream access methods to a full-blown client implementation to be able to switch stream metadata on the fly. This would be quite a rewrite of both plugouts and I did not want to do that.As the current filename now is available in the plugouts, we could use it in file writing operations (MIDI, VGM or WAV plugouts using
file_open()from `filewriter.c) in the future.