clear mapped RAM on subsong change #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrehkopf
approved these changes
Apr 14, 2024
mapper.c
Outdated
| @@ -246,3 +254,7 @@ struct mapper *mapper_gb(struct gbcpu *gbcpu, const uint8_t *rom, size_t size, u | |||
| void mapper_free(struct mapper *m) { | |||
| free(m); | |||
| } | |||
|
|
|||
| void mapper_init(struct mapper *m) { | |||
| memset(m->ram, 0, MAPPER_MAX_EXTRAM_SIZE); | |||
There was a problem hiding this comment.
Maybe assert(sizeof(m->ram) == MAPPER_MAX_EXTRAM_SIZE) beforehand, or use sizeof(m->ram) as the count?
|
"mapped external cartridge mapped" in the message for 2f6a309 should probably be "mapped external cartridge RAM" ;-) |
based on git history
On a subsong change the player has to reset the CPU, registers, RAM etc. Until now the mapped external cartridge RAM was not reset, which could make state from one subsong spill over into the next. Depending on the player routine and subsong sequence this could lead to playback errors. This fixes issue #124.
mmitch
force-pushed
the
reset-mapped-ram
branch
from
2f6a309
to
d44670b
Compare
|
I have added both changes (went with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #124.
I know @mrehkopf has already fixed the bug locally, but there was no pull request yet and it's only 6 lines of code ;-)
He did most of the debugging, that's not my achievement.
Please have a good look at my commit message and HISTORY entry, I'm not sure if they are comprehensible and if I have used the correct technical terms. I'm open for better wording :)