Alsa underrun fix and pause #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the plugout_alsa "pauses" playback simply by ceasing to call `snd_pcm_writei()`; this causes a buffer underrun error on resuming playback, and omission of one buffer's worth of samples from playback (currently 2048 samples). To mitigate this, check for an underrun retval (`-EPIPE`) after calling `snd_pcm_writei()` and if applicable, recover by calling `snd_pcm_prepare()` and repeating the `snd_pcm_writei()` call to avoid dropping samples. Also implement an `alsa_pause()` function to pause and resume playback without a buffer underrun using `snd_pcm_pause()`. The call will be ineffective if unsupported by underlying hardware, in which case the buffer underrun handling above will come into play.
Don't try to pause the ALSA sound device if the device does not support the pause operation. Also report errors on pause/resume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrehkopf also provided a fix for #127 – we'll take his version and add the "check ALSA device for pause support" commit on top.
The failing MacOS build check can be ignored: On first glance it looks like something with i18n has changed (new version of the build agent with different packages installed?), this should have nothing to do with our ALSA plugout changes.