Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LockFreeImmortalSpace should not assume it can use the whole heap range #314

Closed
qinsoon opened this issue May 14, 2021 · 0 comments · Fixed by #1003
Closed

LockFreeImmortalSpace should not assume it can use the whole heap range #314

qinsoon opened this issue May 14, 2021 · 0 comments · Fixed by #1003
Labels
A-space Area: Space/PageResource C-bug Category: Bug F-good-first-issue Call For Participation: Suitable issues for first-time contributors

Comments

@qinsoon
Copy link
Member

qinsoon commented May 14, 2021

LockFreeImmortalSpace now uses the address range between AVAILABLE_START and AVAILABLE_START + total_bytes. This means it won't work if we use other spaces along with this space.

The plan nogc_lock_free currently is only used by OpenJDK, and OpenJDK does not allocate into any other space other than the space bound with the default allocator (i.e. the LockFreeImmortalSpace for nogc_lock_free). So we are not seeing an issue.
@qinsoon qinsoon added C-bug Category: Bug A-space Area: Space/PageResource labels May 14, 2021
@qinsoon qinsoon added the F-good-first-issue Call For Participation: Suitable issues for first-time contributors label May 14, 2023
@qinsoon qinsoon mentioned this issue Oct 30, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
@qinsoon
Implement get_gc_trigger() for LockFreeImmortalSpace (#1003)
91191be 
This PR fixes two issues in `LockFreeImmortalSpace` and adds a test.
* Implemented `get_gc_trigger()`. As `LockFreeImmortalSpace` does not
have `CommonSpace`, we cannot use the default implementation.
* Properly reserve space with `HeapMeta`, so the address range of
`LockFreeImmortalSpace` won't clash with other spaces. This closes
#314.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-space Area: Space/PageResource C-bug Category: Bug F-good-first-issue Call For Participation: Suitable issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement get_gc_trigger() for LockFreeImmortalSpace qinsoon/mmtk-core
1 participant
@qinsoon