Adding feature to query the fragmentation of immixspace #1089
+271
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
reviewed
Feb 29, 2024
wenyuzhao
reviewed
Mar 4, 2024
| dist.live_lines += Block::LINES; | ||
| } | ||
| BlockState::Reusable { unavailable_lines } => { | ||
| dist.live_lines += unavailable_lines as usize; |
There was a problem hiding this comment.
Is this number equivalent to linearly scan the line mark table and manually check the line mark bytes? Probably better to add an assertion to double check. Same as L506.
There was a problem hiding this comment.
I've added an assertion in the latest commit that compares the number of live lines by just iterating the lines in the block and checking the mark table with the number from the block state. Is that what you meant?
k-sareen
reviewed
Mar 5, 2024
…tation-immixspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can use the
count_live_bytes_in_gcfeature to check the total fragmentation of the heap, by counting the bytes of all objects that are scanned and dividing that by the total number of pages used by MMTk.I have introduced a new feature
dump_memory_statswhich at the moment, simply print some stats about memory usage inimmixspace(live bytes, lines, blocks and used pages) andlos(live bytes and used pages). These stats should be useful to investigate heap occupation and fragmentation.