Use SFTDenseChunkMap on 64bits when vm_space is enabled #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issues found in mmtk/mmtk-julia#143.
Basically we should not use
SFTSpaceMap
when we have off-heap memory. Julia tries to set VM space at an address range outside our heap range, and that causes issues when we compute index forSFTSpaceMap
. UsingSFTDenseChunkMap
will solve the issue.Changes:
SFTDenseChunkMap
ifvm_space
is enabled.SFTSpaceMap::has_sft_entry()
. The address/index computation is only correct if the address is in the range.