Rename associated types in GCWorkContext #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR renames `ProcessEdgesWorkType` to `NormalProcessEdges`, and
renames `TPProcessEdges` to `PinningProcessEdges`.
The old name `TPProcessEdges` was very confusing because the type alone
is not sufficient to implement transitive pinning roots. We rename it
to PinningProcessEdges, removing "transitive" from its name. We also
renamed `ProcessEdgesWorkType` to `NormalProcessEdges` for symmetry.
FYI, non-transitive and transitive pinning roots are implemented using a
combination of `NormalProcessEdges` and `PinningProcessEdges`.
- We use `PinningProcessEdges` for objects directly pointed from
non-transitive pinning roots, but `NormalProcessEdges` for their
descendents.
- We use `PinningProcessEdges` to trace all objects reachable from
transitive pinning roots.
|
|
|
I did the obvious change -- renaming those type members and some generic type arguments. I considered making |
Yes. That sounds better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the associated types
ProcessEdgesWorkTypetoDefaultProcessEdges, andTPProcessEdgestoPinningProcessEdges.The old name
TPProcessEdgeswas very confusing because that type alone is not sufficient to implement transitive pinning roots. We rename it toPinningProcessEdges, removing "transitive" from its name. We also renamedProcessEdgesWorkTypetoDefaultProcessEdgesfor symmetry. We also updated comments to clarify the purposes of those type members.We also updated the type parameters of
ProcessEdgesWorkRootsWorkFactory<VM, DPE, PPE>andProcessRootNode<VM, R2OPE, O2OPE>to clarify their purposes, at the expense of being slightly more verbose.