Use to_address for SFT access #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed convenient methods in `ObjectReference` so that if they use SFT, we use `self.to_address()` to get the address instead of `self.0` which returns the raw address.
wks
added a commit
to wks/mmtk-openjdk
that referenced
this pull request
Apr 17, 2024
Upstream change: mmtk/mmtk-core#1122
wks
added a commit
to wks/mmtk-jikesrvm
that referenced
this pull request
Apr 17, 2024
Upstream change: mmtk/mmtk-core#1122
wks
added a commit
to wks/mmtk-v8
that referenced
this pull request
Apr 17, 2024
Upstream change: mmtk/mmtk-core#1122
wks
added a commit
to wks/mmtk-ruby
that referenced
this pull request
Apr 17, 2024
Upstream change: mmtk/mmtk-core#1122
wks
added a commit
to wks/mmtk-ruby
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122
wks
added a commit
to wks/mmtk-julia
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122
|
binding-refs |
mmtkgc-bot
added a commit
to mmtk/mmtk-v8
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
mmtkgc-bot
added a commit
to mmtk/mmtk-openjdk
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
mmtkgc-bot
added a commit
to mmtk/mmtk-ruby
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
mmtkgc-bot
added a commit
to mmtk/mmtk-julia
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
mmtkgc-bot
added a commit
to mmtk/mmtk-jikesrvm
that referenced
this pull request
Apr 18, 2024
Upstream change: mmtk/mmtk-core#1122 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
qinsoon
pushed a commit
to qinsoon/mmtk-julia
that referenced
this pull request
Apr 24, 2024
Upstream change: mmtk/mmtk-core#1122 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed convenient methods in
ObjectReferenceso that if they use SFT, we useself.to_address()to get the address instead ofself.0which returns the raw address.Also removed
ObjectReference::value()to force users to use the more explicitObjectReference::to_raw_address().