Ensure reference objects are either traced or cleared #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I marked this PR as ready for review. This fixes some obvious problems described in #1125, but there are still crashes when running mmtk-openjdk with the reference processor in mmtk-core. For example, running lusearch with StickyImmix with DaCapo Chopin with reference processing enabled will still crash due to SIGSEGV, regardless whether this PR is applied to the master branch or not. As we discussed yesterday, we should enable binding-side reference processing for the OpenJDK binding ASAP. |
qinsoon
reviewed
Apr 23, 2024
Only conditionally add the rescan packet. Add it to the right bucket.
|
The Ruby test failed due to a known problem mmtk/ruby#67 I'll re-run the Ruby test. |
qinsoon
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After retaining soft references, we postpone the scanning of soft references until the transitive closure from retained soft references is fully expanded. While tracing and scanning new objects reached from the referents of soft references, new soft references may be discovered, and they will be added to the reference processor. By postponing the scanning, we ensure the newly discovered soft references are scanned, too.
To ensure we do not accidentally enqueue more objects than we should, we no longer call
trace_objectwhen scanning soft, weak and phantom references. Instead, we callObjectReference::get_forwarded_objectto get the forwarded references and referents. We still calltrace_objectwhen retaining soft references, and when forwarding references in MarkCompact during the second transitive closure.Fixes: #1125