Extra assertions for mutators and epilogues #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds assertions about the number of mutators and the list of mutators returned from the VM binding. Also asserts that epilogues are not silently dropped before they are executed. It could happen if a buggy VM binding returns a number of mutators that does not match the actual list of mutators. This should detect bugs like mmtk/mmtk-ruby#84
wks
added a commit
to wks/mmtk-ruby
that referenced
this pull request
Aug 1, 2024
Updated the `ruby` repo revision to fix a bug where the number of mutators returned from `ActivePlan::number_of_mutators` does not match the number of mutators returned from `ActivePlan::mutators`. Also updated the `mmtk-core` repo revision. More assertions are added so that such bugs can be detected earlier. mmtk-core PR: mmtk/mmtk-core#1182 ruby PR: mmtk/ruby#84 Fixes: mmtk#84
|
binding-refs |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mmtkgc-bot
added a commit
to mmtk/mmtk-ruby
that referenced
this pull request
Aug 2, 2024
Updated the `ruby` repo revision to fix a bug where the number of mutators returned from `ActivePlan::number_of_mutators` does not match the number of mutators returned from `ActivePlan::mutators`. Also updated the `mmtk-core` repo revision. More assertions are added so that such bugs can be detected earlier. mmtk-core PR: mmtk/mmtk-core#1182 ruby PR: mmtk/ruby#84 Fixes: #84 --------- Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds assertions about the number of mutators and the list of mutators returned from the VM binding.
Also asserts that epilogues are not silently dropped before they are executed. It could happen if a buggy VM binding returns a number of mutators that does not match the actual list of mutators.
This should detect bugs like mmtk/mmtk-ruby#84