Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip iterating through unallocated memory for MonotonePageResource #1189

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

k-sareen
Copy link
Collaborator

No description provided.

@k-sareen k-sareen requested a review from qinsoon August 28, 2024 00:31
@k-sareen
Copy link
Collaborator Author

It's wholly unnecessary to return the entire chunk when we know where the cursor is.

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Aug 28, 2024
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-sareen k-sareen added this pull request to the merge queue Aug 28, 2024
Merged via the queue into master with commit c320cf3 Aug 28, 2024
40 checks passed
@k-sareen k-sareen deleted the skip-iterate-entire-chunk branch August 28, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants