Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the result for find_prev_non_zero_value_fast to make sure it is in the search range #1192

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Sep 2, 2024

No description provided.

Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This solves the immediate problem. In the future, we may refactor the API so that the user always ask for a lower bound that is aligned to the region size of VO bits so that we won't need this filtering.

@qinsoon qinsoon added this pull request to the merge queue Sep 2, 2024
Merged via the queue into mmtk:master with commit 61987ea Sep 2, 2024
33 checks passed
@qinsoon qinsoon deleted the filter-find-non-zero-value-fast branch September 2, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants