Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert OBJECT_REF_OFFSET_LOWER_BOUND invariant #1194

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

wks
Copy link
Collaborator

@wks wks commented Sep 2, 2024

Do a debug_assert on the invariant of ObjectModel::OBJECT_REF_OFFSET_LOWER_BOUND when calling address.to_object_start::<VM>(). VM bindings may violate this invariant when changing their object models.

@wks wks requested a review from qinsoon September 2, 2024 06:02
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do a `debug_assert` on the invariant of
`ObjectModel::OBJECT_REF_OFFSET_LOWER_BOUND` when calling
`address.to_object_start::<VM>()`.  VM bindings may violate this
invariant when changing their object models.
@wks wks enabled auto-merge September 2, 2024 06:35
@wks wks added this pull request to the merge queue Sep 2, 2024
Merged via the queue into mmtk:master with commit b3385b8 Sep 2, 2024
33 checks passed
@wks wks deleted the fix/assert-orolb branch September 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants