Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for sanity GC #806

Merged
merged 2 commits into from
May 9, 2023
Merged

Some fixes for sanity GC #806

merged 2 commits into from
May 9, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented May 8, 2023

This PR fixes a few issues for sanity GC.

  1. We should not cache roots (for sanity GC) if we are doing sanity GC.
  2. We do not need to schedule the work VMSpecificRoots in sanity GC. The roots are cached.
  3. Reset edge logger before sanity GC. In sanity GC, we will visit the object and edges again. We have to clear what we have logged before.

@qinsoon
Do not cache roots for sanity if we are already in sanity. Do not
f4bdc9f 
schedule VM specific roots work for sanity. Reset edge
logger before sanity GC.
@qinsoon qinsoon marked this pull request as ready for review May 8, 2023 07:08
@qinsoon qinsoon requested a review from wks May 8, 2023 08:35
wks
wks approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit da6e64b into mmtk:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinsoon @wks