Allow bulk set side metadata #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
force-pushed
the
bulk-set-side-metadata
branch
from
0f9bca9
to
081551b
Compare
wks
reviewed
May 8, 2023
wks
reviewed
May 8, 2023
wks
reviewed
May 8, 2023
| /// that the data address range can be mapped to whole metadata bytes, we have to deal with cases that | ||
| /// we need to mask and set certain bits in a metadata byte. | ||
| /// The end address and the end bit are exclusive. | ||
| pub(super) fn set_meta_bits( |
There was a problem hiding this comment.
Just like you parameterised bulk_update_metadata with the update_meta_bits parameter, you can merge set_meta_bits and zero_meta_bits and parameterise the setting/clearing operation with a parameter, too.
There was a problem hiding this comment.
Done. I added update_meta_bits which takes two function arguments, update_bytes and update_bits. set_meta_bits and zero_meta_bits both use update_meta_bits with different update bytes/bits closures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bulk set for side metadata. Similar to bulk zeroing, bulk set will set the side metadata for a given data address range to all 1s (maximum value).