Fix is_live for ImmixSpace
#842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To save time during `Prepare`, we only clear the on-the-side forwarding bits for defrag sources. As a result, blocks which were defrag sources in the previous GC may still have stale forwarding bits from the previous GC. It makes it unreliable to use the forwarding bits alone to test if a given object is forwarded or not. This commit lets `is_alive` also test whether the block is a defrag source before looking at the forwarding bits. If it is not a defrag source, it must not have been forwarded.
qinsoon
added
the
PR-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save time during
Prepare, we only clear the on-the-side forwarding bits for defrag sources. As a result, blocks which were defrag sources in the previous GC may still have stale forwarding bits from the previous GC. It makes it unreliable to use the forwarding bits alone to test if a given object is forwarded or not.This commit lets
is_alivealso test whether the block is a defrag source before looking at the forwarding bits. If it is not a defrag source, it must not have been forwarded.