Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace debug_assert in side_after with assert #873

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Replace debug_assert in side_after with assert #873

merged 2 commits into from
Jul 31, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jul 31, 2023

Closes #871

@qinsoon qinsoon marked this pull request as ready for review July 31, 2023 01:43
@qinsoon qinsoon requested a review from k-sareen July 31, 2023 01:43
k-sareen
k-sareen approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@k-sareen k-sareen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@k-sareen k-sareen merged commit 566f2bd into mmtk:master Jul 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-sareen k-sareen k-sareen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MMTk should signal an error in release mode for incorrect metadata placement
2 participants
@qinsoon @k-sareen