Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discontiguous PageProtect GC support #946

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Discontiguous PageProtect GC support #946

merged 2 commits into from
Sep 7, 2023

Conversation

wenyuzhao
Copy link
Member

This CL fixes PageProtect's memory unprotect calls. When using discontiguous space,

  • If the allocated pages are not in a new chunk, unprotect the pages as before.
  • If the pages are in a new chunk, there can be two cases:
    • If the new chunk is not mapped, no need to unprotect
    • If the new chunk is mapped, this means that the chunk is allocated and released on previous GC epochs before. The GC should unprotect these pages.

@wenyuzhao wenyuzhao added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Sep 6, 2023
@qinsoon
Copy link
Member

qinsoon commented Sep 6, 2023

Can you explain a bit why we need this change? What is the bug before this change?

@wenyuzhao
Copy link
Member Author

Can you explain a bit why we need this change? What is the bug before this change?

This is a necessary fix to make page protect gc be able to run with compressed pointers, which uses discontiguous heap

@qinsoon
Copy link
Member

qinsoon commented Sep 7, 2023

The JikesRVM failure should not be related with the PR. We can rerun the test.

qinsoon
qinsoon approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Sep 7, 2023
Merged via the queue into mmtk:master with commit 62f1dc9 Sep 7, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenyuzhao @qinsoon