Let Map32 use proper synchronization. #951
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: This PR has undergone rudimentary tests with Map32. It works, but it has several problems:
Map32::prev_link
andMap32::next_link
into theMutex
, but much synchronization is still needed to guard the queries of "next contiguous chunks", "contiguous chunks size", etc. It is much easier to replace the doubly linked list with a per-space data structure before doing this PR. See Refactor VMMap and introduce ChunkResource #932 (comment)descriptor_map
is now protected by aMutex
, but it is used bySpace::in_space
which is used byPlanTraceObject
. It will hurt performance. We should replacedescriptor_map
with SFT as we discussed in Refactor VMMap and introduce ChunkResource #932 (comment) before proceeding with this PR.This removes the need of
self_mut
by putting fields into Mutex or converting fields into atomic types.