Expose is_emergency_collection
to VM bindings
#997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_emergency_collection
is useful during weak reference processing. JVMs can choose not to retain referents ofSoftReference
during emergency GC.The
is_emergency_collection
function was moved fromPlan
toGlobalState
in 57af17f. After that, theMMTK:state
field is private and inaccessible to VM bindings. VM bindings that depend on the to-be-deprecated built-inReferenceProcessor
still work because it is part of themmtk
crate, and canmmtk.state.is_emergency_collection
. However, VM bindings that do weak reference processing on the VM side using theScanning::process_weak_refs
API can no longer call that function. This makes this PR unable to merge. In the future, the OpenJDK binding will also need it when it off-loads weak reference processing to the binding side.This PR adds a public API function
MMTK::is_emergency_collection
which can be called by the VM bindings.