Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Only generate migrations if ORM is configured as queue #77

Closed
Lobosque opened this issue Jun 21, 2018 · 2 comments
Closed

Comments

@Lobosque
Copy link

I'm new to symfony and not sure what would be the best way to handle this, but I just noticed that make:migration generates a few tables for the DtcQueueBundle. However, I believe they (or at least some of them) won't ever be used if using other transport layer than the ORM.
I wonder if it would be a good idea to somehow check the configuration to see if ORM is set before adding those tables to the migration.

@mmucklo
Copy link
Owner

mmucklo commented Jun 21, 2018

That's a good point. I don't quite know how to get Doctrine / Doctrine Migrations to exclude certain directories programmatically, but I can look into it.

mmucklo added a commit that referenced this issue Jun 22, 2018
* issue #74 - option to run indefinitely

* update README for issue #77 and also CHANGELOG
@mmucklo
Copy link
Owner

mmucklo commented Jun 22, 2018

Added a comment to the readme about using schema_filter in your config file. That may be all I can reasonably do for now...

@mmucklo mmucklo closed this as completed Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants