Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buzz client factory #1

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

mnavarrocarter
Copy link
Owner

@mnavarrocarter mnavarrocarter commented Jul 10, 2023

Fixes the instantiation of Buzz client to use the new Psr17FactoryDiscovery instead of the deprecated MessageFactoryDiscovery.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
Documentation none
License MIT

What's in this PR?

Change Buzz instantiator from the deprecated MessageFactoryDisvovery to the new Psr17FactoryDiscovery.

Why?

The Buzz Instantiator was using the deprectaed MessageFactoryDiscovery and this was causing an exception when attempting to instantiate Buzz using nyholm/psr7. Changed to the more modern Psr17FactoryDiscovery that does find nyholm/psr7 for Buzz.

Example Usage

Noop

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

Fixes the instantiation of Buzz client to use the new `Psr17FactoryDiscovery` instead of the deprecated `MessageFactoryDiscovery`.
@mnavarrocarter mnavarrocarter changed the title fix: buzz response factory fix: buzz client factory Jul 10, 2023
@mnavarrocarter mnavarrocarter merged commit d0b7412 into 1.x Jul 10, 2023
@mnavarrocarter mnavarrocarter deleted the fix-buzz-response-factory branch July 10, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant