Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deploy_build_artifact.yaml permissions and artifact path #57

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mnbf9rca
Copy link
Owner

@mnbf9rca mnbf9rca commented Jul 23, 2024

Summary by Sourcery

This pull request updates the 'deploy_build_artifact.yaml' workflow by modifying the artifact paths for the 'upload-artifact' and 'publish release' steps, and adds a 'workflow_dispatch' trigger.

  • Build:
    • Updated the artifact path in the 'upload-artifact' step to only include 'dist/*'.
    • Modified the artifact path in the 'publish release' step to include both 'dist/*' and the bundle path from 'attest-artifacts' outputs.
  • CI:
    • Added 'workflow_dispatch' trigger to the 'deploy_build_artifact.yaml' workflow.

@mnbf9rca mnbf9rca merged commit f263ecf into main Jul 23, 2024
3 checks passed
Copy link

sourcery-ai bot commented Jul 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflow file deploy_build_artifact.yaml to include a new trigger (workflow_dispatch) and modifies the paths and permissions for artifact handling and publishing.

File-Level Changes

Files Changes
.github/workflows/deploy_build_artifact.yaml Updated the workflow to include manual triggering and corrected artifact paths for upload and release steps.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The changes to the artifact paths in the upload-artifact and release-action steps seem inconsistent. Consider clarifying the intention behind these changes or ensuring they are consistent across both steps.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant