Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emojis not showing up in 1.0 docs #706

Closed
hoechenberger opened this issue Jan 13, 2023 · 3 comments
Closed

Emojis not showing up in 1.0 docs #706

hoechenberger opened this issue Jan 13, 2023 · 3 comments
Labels
bug Something isn't working documentation

Comments

@hoechenberger
Copy link
Member

Screenshot 2023-01-13 at 21 43 49

When I right-click on one of these boxes and try to open the image in a new tab, I get a 404. So obviously the URLs are somehow broken…

I also thought the emojis would be embedded in the webpage, instead of being retrieved from a CDN. Bummer. I wonder if we can change this.
@hoechenberger hoechenberger added bug Something isn't working documentation labels Jan 13, 2023
@hoechenberger
Copy link
Member Author

I found this one:
twitter/twemoji#580

@hoechenberger
Copy link
Member Author

hoechenberger commented Jan 13, 2023 •
edited
Loading

I think all we need to do is rebuild the 1.0 docs with the latest mkdocs-material 9.0.4/ pymdownx 9.9.1: squidfunk/mkdocs-material#4856

hoechenberger added a commit to hoechenberger/mne-bids-pipeline that referenced this issue Jan 13, 2023
@hoechenberger
Bump required mkdocs-material version to ensure Twemojis work
5864b8c 
See mne-tools#706
@hoechenberger hoechenberger mentioned this issue Jan 13, 2023
Merged
@hoechenberger
Copy link
Member Author

Maybe it doesn't matter after all. 1.0 is outdated, so the impact is low. Closing.

@hoechenberger hoechenberger closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hoechenberger