-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Simplify raw_to_bids #106
Merged
Merged
Changes from 29 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
6dbf9e2
Simplify raw_to_bids
jasmainak 9f1afb2
TST start modifying tests
jasmainak e56fbc5
TST commands + io
jasmainak 2329d6f
DOC update example
jasmainak e12fc43
TST more fixes
jasmainak 3893742
ENH: don't need kind in write_raw_bids
jasmainak 8c6ec21
MAINT change variable names
jasmainak bb8b955
Take care of hpi
jasmainak 9aebb31
FIX for rebase after overwrite PR
jasmainak b56b1c9
TST improve coverage
jasmainak 5a445c5
TST change eeglab checks
jasmainak 208b815
DOC: Update readme.rst
jasmainak c7e2ae4
ENH: address sappelhoff comments
jasmainak afab4e2
FIX tests
jasmainak cc14f9c
ENH: address comments by Matt
jasmainak ef9e116
TST ordering of key-value pairs in filename
jasmainak b402150
ENH: add hpi param
jasmainak e1386b8
TST check kind
jasmainak 2eaccda
TST for keeping same filetype
jasmainak 1cf4e53
DOC minor fixes
jasmainak 47f8e62
WIP: make_bids_basename
jasmainak 976aba0
WIP: don't make read_raw public
jasmainak 5afa95f
WIP: raw.preload=False
jasmainak 2074a66
DOC: Update examples
jasmainak 75b02c9
FIX test
jasmainak 003a811
DOC update quickstart
jasmainak cc5ad78
add comment
jasmainak 2444990
edf example + raw.preload
jasmainak 0ea50dd
TST make circle happy
jasmainak 450310b
FIX --raw_fname -> --raw
jasmainak 2989e65
TST checks for making sure raw data does not change
jasmainak a471299
ENH: Use raw._init_kwargs to check raw.times
jasmainak 30df0b4
DOC: update readme
jasmainak 21c6052
TST make travis and appveyor happy
jasmainak 665fbf5
FIX: address comments by Teon
jasmainak 6e5beea
bids_fname -> bids_basename
jasmainak 4c378c5
misc
agramfort 75b0cb6
root -> output_path and _age_on_date private
jasmainak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to make these functions public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least the
copyfile_brainvision
function is a feature that we also covered in an example: https://mne-tools.github.io/mne-bids/auto_examples/rename_brainvision_files.html#sphx-glr-auto-examples-rename-brainvision-files-pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these are useful functions? I don't know ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they fit on the api page, but I think they should remain public through the utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we have an example using these functions. Do you propose to remove the example too?