Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] BUG: Fix dtype bug for counts #1227

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

larsoner
Copy link
Member

PR Description

Counts should be integers, make them that way by filling with -1 then converting to pandas Int64Dtype with pd.NA.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Sorry, something went wrong.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87eea28) 97.61% compared to head (8f2655a) 97.61%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          40       40           
  Lines        8685     8686    +1     
=======================================
+ Hits         8478     8479    +1     
  Misses        207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agramfort agramfort merged commit 4fd0ba0 into mne-tools:main Feb 16, 2024
18 checks passed
@agramfort
Copy link
Member

thx @larsoner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants