[MRG] FIX error with unknown coil types #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 93.39% 93.38% -0.02%
==========================================
Files 14 14
Lines 924 922 -2
==========================================
- Hits 863 861 -2
Misses 61 61
Continue to review full report at Codecov.
|
jasmainak
force-pushed
the
fix_coil_error
branch
from
1d9d19a
to
818ee3a
Compare
This was referenced Nov 7, 2018
Merged
sappelhoff
requested changes
Nov 9, 2018
Co-Authored-By: jasmainak <jasmainak@users.noreply.github.com>
jasmainak
changed the title
sappelhoff
approved these changes
Nov 10, 2018
|
+1 for merge if you are ready @jasmainak |
|
yes, ready! |
|
thanks @jasmainak! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128
@hstojic can you check if this fixes the problem on your data? Thanks!